| Summary: | [clang-tidy] Run modernize-use-using over WTF | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Don Olmstead <don.olmstead> | ||||
| Component: | Web Template Framework | Assignee: | Don Olmstead <don.olmstead> | ||||
| Status: | ASSIGNED --- | ||||||
| Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, darin, ews-watchlist | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Don Olmstead
2020-05-08 11:57:59 PDT
Created attachment 398878 [details]
WIP Patch
Current problematic constructs with the modernizer.
Had some issues with these typedefs
- typedef T* (PackedAlignedPtr::*UnspecifiedBoolType);
+ using UnspecifiedBoolType = T *(PackedAlignedPtr<T, >::*);
It will totally destroy typedef enum code but we probably shouldn't be using those constructs anyways.
typedef enum {
LenientConversion,
StrictConversion,
StrictConversionReplacingUnpairedSurrogatesWithFFFD,
} ConversionMode;
Did have some issues with removing typedefs in Variant.h
Could do a quick pass first to remove all the "typedef enum" in the tree: Should be a mechanical process. |