| Summary: | webkitpy: Use apple_additions certificate path if available | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||||||
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | aakash_jain, ews-watchlist, glenn, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Jonathan Bedard
2020-05-07 10:45:52 PDT
Created attachment 398762 [details]
Patch
Created attachment 398770 [details]
Patch
Comment on attachment 398770 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398770&action=review > Tools/Scripts/webkitpy/results/upload.py:185 > + import certifi Do all the machine have certifi? Should we have a try except here? (In reply to Aakash Jain from comment #3) > Comment on attachment 398770 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=398770&action=review > > > Tools/Scripts/webkitpy/results/upload.py:185 > > + import certifi > > Do all the machine have certifi? Should we have a try except here? Yes. It's a dependency of requests, which we autoinstall in this file. So it's guaranteed to be on your Python path. rs=me Created attachment 398776 [details]
Patch for landing
Committed r261332: <https://trac.webkit.org/changeset/261332> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398776 [details]. |