| Summary: | Delete code for old commit queue | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ap, ews-watchlist, glenn, jbedard, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=211638 | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 213296 | ||||||
| Attachments: |
|
||||||
|
Description
Aakash Jain
2020-05-07 10:18:20 PDT
Created attachment 398755 [details]
Patch
Comment on attachment 398755 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398755&action=review rs=me. Red is beautiful. > Tools/Scripts/webkitpy/tool/steps/validatechangelogs.py:40 > +# This is closely related to the ValidateReviewer step. Is ValidateReviewer still used? Comment on attachment 398755 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398755&action=review >> Tools/Scripts/webkitpy/tool/steps/validatechangelogs.py:40 >> +# This is closely related to the ValidateReviewer step. > > Is ValidateReviewer still used? Yes, ValidateChangeLogAndReviewer class in https://trac.webkit.org/browser/webkit/trunk/Tools/BuildSlaveSupport/ews-build/steps.py#L770 uses 'webkit-patch validate-changelog --check-oops --non-interactive'. ValidateChangelog uses ValidateReviewer when --non-interactive flag is passed. I wonder if anyone uses webkit-patch validate-changelog. (In reply to Alexey Proskuryakov from comment #4) > I wonder if anyone uses webkit-patch validate-changelog. new commit-queue uses it (in https://trac.webkit.org/browser/webkit/trunk/Tools/BuildSlaveSupport/ews-build/steps.py#L770) In new commit-queue, I simply used webkit-patch validate-changelog to perform changelog and reviewer validation. There is a large amount of logic which I did not want to re-implement/duplicate (so as to implement new commit-queue quickly). Especially logic to do fuzzy match for reviewer name/email/variation-of-name (e.g: matching 'Tim H' with 'Tim Horton'). Committed r261319: <https://trac.webkit.org/changeset/261319> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398755 [details]. |