| Summary: | Make debug build run in accessibility isolated mode = 1. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andres Gonzalez <andresg_22> | ||||||
| Component: | New Bugs | Assignee: | Andres Gonzalez <andresg_22> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aboxhall, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Andres Gonzalez
2020-05-07 07:00:58 PDT
Created attachment 398735 [details]
Patch
Comment on attachment 398735 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398735&action=review > Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:-481 > - if (!isMainThread()) { Can we leave this !iSMainThread but check which isolated tree mode we're in? and better yet add another assert? > Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:860 > + if (auto tree = this->tree()) same here > Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:290 > + ASSERT(m_changeLogLock.isLocked()); do we need to add the same thing for the focused node? Created attachment 398742 [details]
Patch
Committed r261300: <https://trac.webkit.org/changeset/261300> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398742 [details]. |