| Summary: | Give the DFG and FTL WorkList threads more stack space on ASAN builds. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||||
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ap, benjamin, cdumez, cmarcelo, ews-watchlist, ggaren, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=211547 | ||||||||
| Attachments: |
|
||||||||
|
Description
Mark Lam
2020-05-06 15:17:42 PDT
Created attachment 398678 [details]
proposed patch.
/Volumes/Data/worker/macOS-Mojave-Release-Build-EWS/build/Source/WTF/wtf/Threading.cpp:48:46: error: unused parameter 'threadType' [-Werror,-Wunused-parameter] Created attachment 398680 [details]
proposed patch.
Comment on attachment 398680 [details]
proposed patch.
r=me
(In reply to Alexey Proskuryakov from comment #6) > Will you be rolling back r260692 separately? Yes. Because there's another fix that I need to land first (work in progress). This bug is only 1 of 2 fixes. (In reply to Mark Lam from comment #7) > (In reply to Alexey Proskuryakov from comment #6) > > Will you be rolling back r260692 separately? > > Yes. Because there's another fix that I need to land first (work in > progress). This bug is only 1 of 2 fixes. The SUPPRESS_ASAN has been undone in r261325 for https://webkit.org/b/211547. Comment on attachment 398680 [details]
proposed patch.
Thanks for the review. Landing now.
Committed r261328: <https://trac.webkit.org/changeset/261328> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398680 [details]. |