Bug 211532

Summary: Add a test for `REGRESSION (r260753): Frequent crashes under TextIndicator's estimatedTextColorsForRange`
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, webkit-bot-watchers-bugzilla, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=211523
Attachments:
Description Flags
Patch none

Description Tim Horton 2020-05-06 14:30:47 PDT
Add a test for `REGRESSION (r260753): Frequent crashes under TextIndicator's estimatedTextColorsForRange`
Comment 1 Tim Horton 2020-05-06 14:31:09 PDT
Created attachment 398658 [details]
Patch
Comment 2 EWS 2020-05-06 14:54:07 PDT
Committed r261251: <https://trac.webkit.org/changeset/261251>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398658 [details].
Comment 3 Radar WebKit Bug Importer 2020-05-06 14:55:14 PDT
<rdar://problem/62946934>
Comment 4 Aakash Jain 2020-05-07 08:34:17 PDT
(In reply to EWS from comment #2)
> Committed r261251: <https://trac.webkit.org/changeset/261251>
The newly added test fast/text-indicator/text-indicator-estimated-color-with-implicit-newline.html seems to be failing consistently on ios-wk2, as also indicated by red ews bubble.

History: https://results.webkit.org/?suite=layout-tests&test=fast%2Ftext-indicator%2Ftext-indicator-estimated-color-with-implicit-newline.html
Comment 5 Ryan Haddad 2020-05-07 09:23:41 PDT
Reverted r261251 for reason:

Test is failing on iOS

Committed r261295: <https://trac.webkit.org/changeset/261295>
Comment 6 Tim Horton 2020-05-07 11:39:20 PDT
https://trac.webkit.org/changeset/261321/webkit