| Summary: | [WPE][Qt] Enable by default | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||||||
| Component: | WPE WebKit | Assignee: | Philippe Normand <pnormand> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | annulen, aperez, bugs-noreply, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio | ||||||||
| Priority: | P2 | ||||||||||
| Version: | WebKit Local Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Philippe Normand
2020-05-06 08:56:17 PDT
Created attachment 398623 [details]
Patch
Comment on attachment 398623 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398623&action=review > Source/cmake/OptionsWPE.cmake:84 > +WEBKIT_OPTION_DEFINE(ENABLE_WPE_QT_API "Whether to enable support for the Qt5/QML plugin" PUBLIC ON) I would imagine most packagers are not building the Qt API, so enabling it by default will break their build scripts. How about making this depend on ${ENABLE_DEVELOPER_MODE} or ${ENABLE_EXPERIMENTAL_FEATURES}? Created attachment 398626 [details]
Patch
(In reply to Adrian Perez from comment #2) > Comment on attachment 398623 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=398623&action=review > > > Source/cmake/OptionsWPE.cmake:84 > > +WEBKIT_OPTION_DEFINE(ENABLE_WPE_QT_API "Whether to enable support for the Qt5/QML plugin" PUBLIC ON) > > I would imagine most packagers are not building the Qt API, so enabling it > by default will break their build scripts. How about making this depend on > ${ENABLE_DEVELOPER_MODE} or ${ENABLE_EXPERIMENTAL_FEATURES}? SGTM :) Created attachment 398627 [details]
Patch
Committed r261275: <https://trac.webkit.org/changeset/261275> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398627 [details]. |