Bug 211517

Summary: [WPE][Qt] Enable by default
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WPE WebKitAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, aperez, bugs-noreply, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Philippe Normand
Reported 2020-05-06 08:56:17 PDT
Now that the EWS and bots use the Flatpak SDK, Qt5 libs are available.
Attachments
Patch (1.63 KB, patch)
2020-05-06 08:59 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Patch (2.76 KB, patch)
2020-05-06 09:27 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Patch (2.78 KB, patch)
2020-05-06 09:29 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2020-05-06 08:59:07 PDT
Created attachment 398623 [details] Patch
Adrian Perez
Comment 2 2020-05-06 09:21:09 PDT
Comment on attachment 398623 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398623&action=review > Source/cmake/OptionsWPE.cmake:84 > +WEBKIT_OPTION_DEFINE(ENABLE_WPE_QT_API "Whether to enable support for the Qt5/QML plugin" PUBLIC ON) I would imagine most packagers are not building the Qt API, so enabling it by default will break their build scripts. How about making this depend on ${ENABLE_DEVELOPER_MODE} or ${ENABLE_EXPERIMENTAL_FEATURES}?
Philippe Normand
Comment 3 2020-05-06 09:27:29 PDT
Created attachment 398626 [details] Patch
Philippe Normand
Comment 4 2020-05-06 09:28:00 PDT
(In reply to Adrian Perez from comment #2) > Comment on attachment 398623 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=398623&action=review > > > Source/cmake/OptionsWPE.cmake:84 > > +WEBKIT_OPTION_DEFINE(ENABLE_WPE_QT_API "Whether to enable support for the Qt5/QML plugin" PUBLIC ON) > > I would imagine most packagers are not building the Qt API, so enabling it > by default will break their build scripts. How about making this depend on > ${ENABLE_DEVELOPER_MODE} or ${ENABLE_EXPERIMENTAL_FEATURES}? SGTM :)
Philippe Normand
Comment 5 2020-05-06 09:29:23 PDT
Created attachment 398627 [details] Patch
EWS
Comment 6 2020-05-07 01:40:05 PDT
Committed r261275: <https://trac.webkit.org/changeset/261275> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398627 [details].
Note You need to log in before you can comment on or make changes to this bug.