| Summary: | [WebXR] Implement simulateUserActivation() | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sergio Villar Senin <svillar> | ||||
| Component: | New Bugs | Assignee: | Sergio Villar Senin <svillar> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | darin, dino, svillar, webkit-bug-importer, youennf, zan | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 211130 | ||||||
| Attachments: |
|
||||||
|
Description
Sergio Villar Senin
2020-05-06 08:46:50 PDT
Created attachment 398622 [details]
Patch
Comment on attachment 398622 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398622&action=review > Source/WebCore/testing/WebXRTest.cpp:105 > + function.handleEvent(); it might be better to follow Internals::withUserGesture. Something like: UserGestureIndicator gestureIndicator(ProcessingUserGesture, document); function.handleEvent(); (In reply to youenn fablet from comment #2) > Comment on attachment 398622 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=398622&action=review > > > Source/WebCore/testing/WebXRTest.cpp:105 > > + function.handleEvent(); > > it might be better to follow Internals::withUserGesture. > Something like: > UserGestureIndicator gestureIndicator(ProcessingUserGesture, document); > function.handleEvent(); Much better indeed. I'll replace it before landing. Committed r261273: <https://trac.webkit.org/changeset/261273> Comment on attachment 398622 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398622&action=review > Source/WebCore/testing/XRSimulateUserActivationFunction.h:42 > + virtual CallbackResult<void> handleEvent(void) = 0; This (void) syntax is never needed in C++. It is sometimes needed in old C code. Just use "()". |