| Summary: | Regression(r254859) DOM storage event gets fired at the frame that caused the storage modification | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | pirimoglu | ||||
| Component: | WebKit Misc. | Assignee: | Chris Dumez <cdumez> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | achristensen, beidson, cdumez, darin, ggaren, merihakar, mjs, sihui_liu, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Safari 13 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=210512 | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 206433 | ||||||
| Attachments: |
|
||||||
|
Description
pirimoglu
2020-05-06 03:47:43 PDT
Will fix shortly. Thanks for the bug report. Created attachment 399997 [details]
Patch
pirimoglu@hotmail.com: I don't think we shipped this bug yet. Were you testing Safari Technology Preview? No, released product. It starts with Safari 13.1, from end user complaints and what we tested. I think you are testing your fix with only window.sessionStorage, but not with window.localStorage. I went back and tested this with the Safari 13.1, both with sessionStorage and localStorage. In Safari 13.1, sessionStorage is working as expected. But localStorage has this problem, which is what our javascript is using on our site. Comment on attachment 399997 [details]
Patch
r=me
commit-queue failed to commit attachment 399997 [details] to WebKit repository.
Comment on attachment 399997 [details] Patch Clearing flags on attachment: 399997 Committed r262058: <https://trac.webkit.org/changeset/262058> All reviewed patches have been landed. Closing bug. Can you please confirm or verify if the fix with localStorage still work when there are two or more browser tabs open that share the same localStorage, due to being on same url or same origin? If one of these windows had modified the localStorage, the other windows should receive the storage event, but not the originating window. Our javascript code is relying on this. Wanted to confirm this will still be case and not regress. Just in case this may be behaving differently than iframe on the same page case. Thanks for the fix! (In reply to pirimoglu from comment #11) > Can you please confirm or verify if the fix with localStorage still work > when there are two or more browser tabs open that share the same > localStorage, due to being on same url or same origin? > > If one of these windows had modified the localStorage, the other windows > should receive the storage event, but not the originating window. Our > javascript code is relying on this. Wanted to confirm this will still be > case and not regress. > > Just in case this may be behaving differently than iframe on the same page > case. > > Thanks for the fix! Yes, I have just verified that it works as expected, even with multiple tabs. You should be able to validate this too in the next Safari Technology Preview build. Thanks again! *** Bug 210512 has been marked as a duplicate of this bug. *** |