| Summary: | fast/overflow/horizontal-scroll-after-back.html is a flaky timeout on macOS | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
| Component: | Tools / Tests | Assignee: | Chris Dumez <cdumez> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | darin, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=215778 | ||||||||
| Attachments: |
|
||||||||
|
Description
Chris Dumez
2020-05-05 14:51:40 PDT
Created attachment 398554 [details]
Patch
Comment on attachment 398554 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398554&action=review > LayoutTests/fast/overflow/horizontal-scroll-after-back.html:20 > + window.sessionStorage.horizontal_scroll_after_back_test_started = true; I don’t think we need the "window." here. > LayoutTests/fast/overflow/horizontal-scroll-after-back.html:30 > + window.setTimeout("navigateAwayAndBack()", 0); I don’t think we need the "window." here. > LayoutTests/fast/overflow/horizontal-scroll-after-back.html:37 > + if (!window.sessionStorage.horizontal_scroll_after_back_test_started) > + return; > + delete window.sessionStorage.horizontal_scroll_after_back_test_started; I don’t think we need the "window." here. Created attachment 398556 [details]
Patch
Committed r261205: <https://trac.webkit.org/changeset/261205> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398556 [details]. |