| Summary: | [JSC] JSBigInt::maxLengthBits and JSBigInt::maxLength are wrong | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, ticaiolima, tzagallo, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Yusuke Suzuki
2020-05-05 07:28:05 PDT
Created attachment 398502 [details]
Patch
Comment on attachment 398502 [details]
Patch
LGTM. I'm wondering if we want to static assert that `maxLengthBits % (sizeof(Digit) * bitsPerByte) == 0`. IIUC, if this is not true, we will have `maxLengthBits` not aligned with `maxLength`.
(In reply to Caio Lima from comment #2) > Comment on attachment 398502 [details] > Patch > > LGTM. I'm wondering if we want to static assert that `maxLengthBits % > (sizeof(Digit) * bitsPerByte) == 0`. IIUC, if this is not true, we will have > `maxLengthBits` not aligned with `maxLength`. Sounds nice. Created attachment 398505 [details]
Patch
Comment on attachment 398505 [details]
Patch
r=me
Comment on attachment 398505 [details]
Patch
Undoing can+ for now to let EWS run.
(In reply to Mark Lam from comment #6) > Comment on attachment 398505 [details] > Patch > > Undoing can+ for now to let EWS run. Ah autocorrect: /can+/cq+/ Comment on attachment 398505 [details]
Patch
EWS gets green, landing
Committed r261174: <https://trac.webkit.org/changeset/261174> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398505 [details]. |