Bug 211409

Summary:

Tapping to focus editable elements should start caret selection at word boundary

Product:

WebKit

Reporter:

Wenson Hsieh <wenson_hsieh>

Component:

HTML Editing

Assignee:

Wenson Hsieh <wenson_hsieh>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, ews-watchlist, megan_gardner, mifenton, thorton, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
For EWS	none
Patch	none

Description Wenson Hsieh 2020-05-04 16:00:26 PDT Comment hidden (obsolete)

<rdar://problem/59893301>

Comment 1 Wenson Hsieh 2020-05-04 16:13:31 PDT Comment hidden (obsolete)

Created attachment 398430 [details]
For EWS

Comment 2 Wenson Hsieh 2020-05-04 17:32:36 PDT

Created attachment 398441 [details]
Patch

Comment 3 Wenson Hsieh 2020-05-04 17:32:57 PDT

<rdar://problem/62869098>

Comment 4 Megan Gardner 2020-05-04 18:16:18 PDT

Comment on attachment 398441 [details]
Patch

Great renaming and refactoring. I was on the fence about the WordIsNearTap flag, but I convinced myself that you are right.

Comment 5 Daniel Bates 2020-05-04 18:17:26 PDT

Patch is ok as is. No change needed. Code is optimal as is, there is an Apple internal reason. Ping me or wait for bug to drop.

Comment 6 EWS 2020-05-04 19:45:28 PDT

Committed r261139: <https://trac.webkit.org/changeset/261139>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398441 [details].