| Summary: | WKWebView.title should be safe browsing warning's title during a safe browsing warning | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | thorton, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Alex Christensen
2020-05-04 15:02:26 PDT
Created attachment 398422 [details]
Patch
Comment on attachment 398422 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398422&action=review > Source/WebKit/UIProcess/WebPageProxy.cpp:5213 > + m_pageLoadState.setTitle(transaction, oldTitle); I don't really know how this all works, is there a guarantee that neither parsing nor JS have changed the title in the meantime, that you'll lose/stomp here? There is no such guarantee. This is just a best attempt at restoring what was there. The title is from a non-malicious page. Created attachment 398796 [details]
Patch
Committed r261390: <https://trac.webkit.org/changeset/261390> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398796 [details]. |