| Summary: | Make __IPHONE_OS_VERSION_MIN_REQUIRED checks against old versions explicit about watchOS and tvOS | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> | ||||
| Component: | New Bugs | Assignee: | Darin Adler <darin> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ap, ews-watchlist, mifenton, mmaxfield, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Darin Adler
2020-05-04 14:44:28 PDT
Created attachment 398447 [details]
Patch
Comment on attachment 398447 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398447&action=review > Source/WebKit/ChangeLog:12 > + * Platform/spi/ios/UIKitSPI.h: Move from __IPHONE_OS_VERSION_MIN_REQUIRED to > + PLATFORM(IOS) in one place, and in the other removed the conditional entirely. I went back here to find out why there isn't a comment about watchOS and tvOS in the code. > Source/WebCore/page/SettingsDefaultValues.h:109 > +#if PLATFORM(COCOA) && !(PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 101400) && !PLATFORM(APPLETV) There is no __MAC_OS_X_VERSION_MIN_REQUIRED < 101400. > Source/WebCore/platform/graphics/cg/GradientCG.cpp:187 > +#if PLATFORM(COCOA) && !(PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 101400) && !PLATFORM(APPLETV) Ditto. > Source/WebKit/NetworkProcess/NetworkActivityTracker.h:31 > +#if USE(APPLE_INTERNAL_SDK) && PLATFORM(COCOA) && !(PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 101400) && !PLATFORM(APPLETV) There is no __MAC_OS_X_VERSION_MIN_REQUIRED < 101400. > Source/WebKit/Shared/WebPreferencesDefaultValues.h:225 > +#if PLATFORM(COCOA) && !(PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 101400) && !PLATFORM(APPLETV) There is no __MAC_OS_X_VERSION_MIN_REQUIRED < 101400. > Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:352 > +#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400) || PLATFORM(IOS) It's always __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400 Comment on attachment 398447 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398447&action=review >> Source/WebKit/ChangeLog:12 >> + PLATFORM(IOS) in one place, and in the other removed the conditional entirely. > > I went back here to find out why there isn't a comment about watchOS and tvOS in the code. Added a comment about that to the change log. >> Source/WebCore/page/SettingsDefaultValues.h:109 >> +#if PLATFORM(COCOA) && !(PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 101400) && !PLATFORM(APPLETV) > > There is no __MAC_OS_X_VERSION_MIN_REQUIRED < 101400. I’ll take care of all of these. Committed r261138: <https://trac.webkit.org/changeset/261138> |