Bug 211397

Summary: Excessive error logging from daemons trying to use WebKit, under -[UIDevice currentDevice]
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, darin, simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Tim Horton 2020-05-04 14:01:02 PDT 
Excessive error logging from daemons trying to use WebKit, under -[UIDevice currentDevice]
Comment 1 Tim Horton 2020-05-04 14:01:17 PDT 
Created attachment 398409 [details]
Patch
Comment 2 Tim Horton 2020-05-04 14:01:19 PDT 
<rdar://problem/61635403>
Comment 3 EWS 2020-05-04 15:11:47 PDT 
Committed r261117: <https://trac.webkit.org/changeset/261117>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398409 [details].
Comment 4 Tim Horton 2020-05-04 18:18:45 PDT 
Reverted r261117 for reason:

broke

Committed r261135: <https://trac.webkit.org/changeset/261135>
Comment 5 Darin Adler 2020-05-04 23:52:55 PDT 
Comment on attachment 398409 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398409&action=review

> Source/WebKit/Shared/UserInterfaceIdiom.mm:46
> +    // If we are in a dameon, we cannot use UIDevice. Fall back to checking the hardware itself.

typo in "daemon" here
Comment 6 Tim Horton 2020-05-05 00:42:32 PDT 
Created attachment 398487 [details]
Patch
Comment 7 Tim Horton 2020-05-05 00:43:30 PDT 
Created attachment 398488 [details]
Patch
Comment 8 EWS 2020-05-05 02:03:25 PDT 
Committed r261157: <https://trac.webkit.org/changeset/261157>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398488 [details].