| Summary: | Stop hard-coding get-task-allow entitlement for simulator builds | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
| Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ap, ggaren, krollin, thorton, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=211254 | ||||||||
| Attachments: |
|
||||||||
|
Description
Chris Dumez
2020-05-04 12:48:15 PDT
Created attachment 398402 [details]
Patch
Created attachment 398405 [details]
Patch
Comment on attachment 398405 [details]
Patch
Ok, I have validated the change locally. Turns out that the get-task-allow entitlement gets added to the signature and thus applies to the host system, while the runningboard entitlement gets added to the __entitlement section of the binary and thus only applies inside the simulator.
Comment on attachment 398405 [details]
Patch
r=me
Committed r261116: <https://trac.webkit.org/changeset/261116> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398405 [details]. |