Bug 211387

Summary: Allow SharedBuffer to be backed by SharedMemory.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: NEW    
Severity: Normal CC: achristensen
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP none

Jer Noble
Reported 2020-05-04 10:06:11 PDT
Allow SharedBuffer to be backed by SharedMemory.
Attachments
WIP (241.98 KB, patch)
2020-05-04 10:08 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2020-05-04 10:06:33 PDT
This will require moving SharedMemory (and also Attachment and MachPort) into PAL.
Jer Noble
Comment 2 2020-05-04 10:08:17 PDT
Created attachment 398384 [details] WIP
Alex Christensen
Comment 3 2020-05-04 10:16:14 PDT
Comment on attachment 398384 [details] WIP View in context: https://bugs.webkit.org/attachment.cgi?id=398384&action=review > Source/WebCore/PAL/SharedMemory.h:59 > +class SharedMemory : public RefCounted<SharedMemory> { Why are there two SharedMemory.h? > Source/WebKit/Platform/SharedMemory.h:29 > +#include <pal/system/SharedMemory.h> We should remove this header whose only purpose is to include another.
Jer Noble
Comment 4 2020-05-04 13:56:16 PDT
(In reply to Alex Christensen from comment #3) > Comment on attachment 398384 [details] > WIP > > View in context: > https://bugs.webkit.org/attachment.cgi?id=398384&action=review > > > Source/WebCore/PAL/SharedMemory.h:59 > > +class SharedMemory : public RefCounted<SharedMemory> { > > Why are there two SharedMemory.h? > > > Source/WebKit/Platform/SharedMemory.h:29 > > +#include <pal/system/SharedMemory.h> > > We should remove this header whose only purpose is to include another. That was a failed experiment to try to reduce the number of changes needed inside of Source/WebKit/. Yeah, it's not necessary.
Alex Christensen
Comment 5 2020-05-04 14:02:45 PDT
Comment on attachment 398384 [details] WIP View in context: https://bugs.webkit.org/attachment.cgi?id=398384&action=review > Source/WebCore/DerivedSources-input.xcfilelist:1190 > +ApplePaySetupFeatureType.idl Also this should not be in this patch. If it's needed it should be separate.
Note You need to log in before you can comment on or make changes to this bug.