| Summary: | Allow SharedBuffer to be backed by SharedMemory. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||
| Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||
| Status: | NEW --- | ||||||
| Severity: | Normal | CC: | achristensen | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Jer Noble
2020-05-04 10:06:11 PDT
This will require moving SharedMemory (and also Attachment and MachPort) into PAL. Created attachment 398384 [details]
WIP
Comment on attachment 398384 [details] WIP View in context: https://bugs.webkit.org/attachment.cgi?id=398384&action=review > Source/WebCore/PAL/SharedMemory.h:59 > +class SharedMemory : public RefCounted<SharedMemory> { Why are there two SharedMemory.h? > Source/WebKit/Platform/SharedMemory.h:29 > +#include <pal/system/SharedMemory.h> We should remove this header whose only purpose is to include another. (In reply to Alex Christensen from comment #3) > Comment on attachment 398384 [details] > WIP > > View in context: > https://bugs.webkit.org/attachment.cgi?id=398384&action=review > > > Source/WebCore/PAL/SharedMemory.h:59 > > +class SharedMemory : public RefCounted<SharedMemory> { > > Why are there two SharedMemory.h? > > > Source/WebKit/Platform/SharedMemory.h:29 > > +#include <pal/system/SharedMemory.h> > > We should remove this header whose only purpose is to include another. That was a failed experiment to try to reduce the number of changes needed inside of Source/WebKit/. Yeah, it's not necessary. Comment on attachment 398384 [details] WIP View in context: https://bugs.webkit.org/attachment.cgi?id=398384&action=review > Source/WebCore/DerivedSources-input.xcfilelist:1190 > +ApplePaySetupFeatureType.idl Also this should not be in this patch. If it's needed it should be separate. |