| Summary: | [Cocoa] Remove a few unneeded __IPHONE_OS_VERSION_MIN_REQUIRED checks | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> | ||||
| Component: | New Bugs | Assignee: | Darin Adler <darin> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Darin Adler
2020-05-04 09:03:51 PDT
Created attachment 398373 [details]
Patch
Comment on attachment 398373 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398373&action=review > Tools/TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:151 > +#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400) || PLATFORM(IOS) || PLATFORM(WATCHOS) || PLATFORM(APPLETV) This check can be removed now, 10.14 is the oldest supported version for macOS. > Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:6534 > #if __IPHONE_OS_VERSION_MIN_REQUIRED > 130400 This can be removed too. We are 13.4+ now. All right. I have some more patches coming up removing even more version checks. Comment on attachment 398373 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398373&action=review >> Tools/TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:151 >> +#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400) || PLATFORM(IOS) || PLATFORM(WATCHOS) || PLATFORM(APPLETV) > > This check can be removed now, 10.14 is the oldest supported version for macOS. OK, will do. >> Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:6534 >> #if __IPHONE_OS_VERSION_MIN_REQUIRED > 130400 > > This can be removed too. We are 13.4+ now. Are you sure? This says > 130400, not >= 130400. Committed r261134: <https://trac.webkit.org/changeset/261134> |