Bug 211354

Summary: Use default initializers and default constructors in WebEvent.h
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: WebKit Misc.Assignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, dbates, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch v1 none

David Kilzer (:ddkilzer)
Reported 2020-05-03 10:56:10 PDT
Use default initializers and default constructors in WebEvent.h. Initially found by the clang static analyzer: class WebPlatformTouchPoint { WebPlatformTouchPoint() { } ← 2 uninitialized fields at the end of the constructor call private: unsigned m_identifier; ^ uninitialized field 'this->m_identifier' WebCore::IntPoint m_location; uint32_t m_phase; ^ uninitialized field 'this->m_phase' };
Attachments
Patch v1 (4.65 KB, patch)
2020-05-03 11:01 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2020-05-03 11:01:11 PDT
Created attachment 398321 [details] Patch v1
Daniel Bates
Comment 2 2020-05-03 12:02:34 PDT
Comment on attachment 398321 [details] Patch v1 Patch looks good. A good future investigation is to identify if the default constructors are needed. If not, remove them and look for ways to reduce default initializers to minimum set because they have a cost.
EWS
Comment 3 2020-05-03 14:42:28 PDT
Committed r261066: <https://trac.webkit.org/changeset/261066> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398321 [details].
Radar WebKit Bug Importer
Comment 4 2020-05-03 14:43:16 PDT
<rdar://problem/62816793>
Note You need to log in before you can comment on or make changes to this bug.