| Summary: | Use default initializers and default constructors in WebEvent.h | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
| Component: | WebKit Misc. | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | darin, dbates, simon.fraser, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 398321 [details]
Patch v1
Comment on attachment 398321 [details]
Patch v1
Patch looks good. A good future investigation is to identify if the default constructors are needed. If not, remove them and look for ways to reduce default initializers to minimum set because they have a cost.
Committed r261066: <https://trac.webkit.org/changeset/261066> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398321 [details]. |
Use default initializers and default constructors in WebEvent.h. Initially found by the clang static analyzer: class WebPlatformTouchPoint { WebPlatformTouchPoint() { } ← 2 uninitialized fields at the end of the constructor call private: unsigned m_identifier; ^ uninitialized field 'this->m_identifier' WebCore::IntPoint m_location; uint32_t m_phase; ^ uninitialized field 'this->m_phase' };