Bug 211348

Summary:

Sometimes cannot find <textarea> in list of editable elements

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

WebCore Misc.

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
To Land	none

Description Daniel Bates 2020-05-03 00:49:39 PDT

Consider a page with the following markup:

[[
<textarea style="width: 500px; height: 500px">So few words to fill such a big space...</textarea>
]]

If you call Page::editableElementsInRect() (directly or via -_requestTextInputContextsInRect:completionHandler:) with a rect that is in an empty part of the <textarea> then it will NOT find it. But it should find it.

Need to add form control bounds to editable region instead of the bounds of its inner text element.

Comment 1 Daniel Bates 2020-05-03 00:49:47 PDT

<rdar://problem/62231067>

Comment 2 Daniel Bates 2020-05-03 01:06:53 PDT

Created attachment 398307 [details]
Patch

Comment 3 Daniel Bates 2020-05-03 01:18:10 PDT

Created attachment 398308 [details]
Patch

Comment 4 Daniel Bates 2020-05-03 06:59:43 PDT

Just need to rebase results of some tests...

Comment 5 Daniel Bates 2020-05-03 13:52:53 PDT

Created attachment 398330 [details]
To Land

Comment 6 Daniel Bates 2020-05-03 13:53:29 PDT

Committed r261065: <https://trac.webkit.org/changeset/261065>

Comment 7 Daniel Bates 2020-05-03 13:53:51 PDT

BTW thanks for the review, Simon!