Bug 211336

Summary:	[GTK] Test /webkit/WebKitWebExtension/user-messages is flaky
Product:	WebKit	Reporter:	Diego Pino <dpino>
Component:	WebKitGTK	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	abstractmachines, bugs-noreply
Priority:	P2
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Diego Pino 2020-05-02 00:22:20 PDT

I started noticing this failure once we switched to Flatpak. Sometimes it returns a failure, other times returns a timeout.

Timeout: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/13599/steps/API%20tests/logs/stdio

GLib-DEBUG: posix_spawn avoided (child_setup specified) 
  /webkit/WebKitWebExtension/user-messages:                           Bail out! ERROR:../../Tools/TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:535:extensionMessageReceivedCallback(WebKitWebExtension*, WebKitUserMessage*)::<lambda(GObject*, GAsyncResult*, gpointer)>: assertion failed (error.get() == NULL): Message Ping was not handled (WebKitUserMessageError, 0)
TIMEOUT

Failure: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/13592/steps/API%20tests/logs/stdio

GLib-DEBUG: posix_spawn avoided (child_setup specified) 
  /webkit/WebKitWebExtension/user-messages:                           Bail out! ERROR:../../Tools/TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:535:extensionMessageReceivedCallback(WebKitWebExtension*, WebKitUserMessage*)::<lambda(GObject*, GAsyncResult*, gpointer)>: assertion failed (error.get() == NULL): Message Ping was not handled (WebKitUserMessageError, 0)
FAIL

Comment 1 Amanda Falke 2023-08-29 15:05:19 PDT

Same issues persist; gardened this here https://github.com/WebKit/WebKit/pull/17203

In https://bugs.webkit.org/show_bug.cgi?id=258883, we removed the failing expectations,
and removed those bug tickets from the expectation file, without noting
or closing the bugs. This patch restores those expectations; same issues
persist in GTK as per this bug.

It also appears that 267125@main didn't resolve those flakiness
issues for this test in particular, e.g. https://bugs.webkit.org/show_bug.cgi?id=260382.

Comment 2 EWS 2023-08-30 01:36:03 PDT

Test gardening commit 267448@main (ceb8e6198351): <https://commits.webkit.org/267448@main>

Reviewed commits have been landed. Closing PR #17203 and removing active labels.

Comment 3 Vitaly Dyackhov 2023-08-30 08:01:26 PDT

Pull request: https://github.com/WebKit/WebKit/pull/17225

Comment 4 EWS 2023-08-30 12:30:41 PDT

Committed 267462@main (fce44888e8cc): <https://commits.webkit.org/267462@main>

Reviewed commits have been landed. Closing PR #17225 and removing active labels.