Bug 211322

Summary: [IPC hardening] Refactor createMessageDecoder() for clarity
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: WebKit2Assignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, useafterfree, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 211260    
Bug Blocks:    
Attachments:
Description Flags
Patch for landing none

David Kilzer (:ddkilzer)
Reported 2020-05-01 14:34:06 PDT
Refactor createMessageDecoder() for clarity. Follow-on based on review comments from Bug 211260.
Attachments
Patch for landing (3.69 KB, patch)
2020-05-01 15:20 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2020-05-01 15:20:44 PDT
Created attachment 398248 [details] Patch for landing
David Kilzer (:ddkilzer)
Comment 2 2020-05-01 15:21:44 PDT
Comment on attachment 398248 [details] Patch for landing This change wes reviewed by Darin in Bug 211260.
David Kilzer (:ddkilzer)
Comment 3 2020-05-01 15:23:11 PDT
(In reply to David Kilzer (:ddkilzer) from comment #2) > Comment on attachment 398248 [details] > Patch for landing > > This change wes reviewed by Darin in Bug 211260. Commit queue tested this patch in Bug 211260 Attachment #398214 [details].
David Kilzer (:ddkilzer)
Comment 4 2020-05-01 15:24:13 PDT
(In reply to David Kilzer (:ddkilzer) from comment #3) > (In reply to David Kilzer (:ddkilzer) from comment #2) > > Comment on attachment 398248 [details] > > Patch for landing > > > > This change wes reviewed by Darin in Bug 211260. > > Commit queue tested this patch in Bug 211260 Attachment #398214 [details]. Commit queue => EWS.
Radar WebKit Bug Importer
Comment 5 2020-05-01 15:25:25 PDT
<rdar://problem/62749634>
David Kilzer (:ddkilzer)
Comment 6 2020-05-01 15:53:23 PDT
Of course someone broke the build just as I uploaded the patch: "WebCore::Page::setCORSDisablingPatterns(WTF::Vector<WebCore::UserContentURLPattern, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&&)", referenced from: WebKit::WebPage::updateCORSDisablingPatterns(WTF::Vector<WTF::String, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&&) in WebPage.o ld: symbol(s) not found for architecture x86_64
EWS
Comment 7 2020-05-01 16:44:52 PDT
Committed r261040: <https://trac.webkit.org/changeset/261040> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398248 [details].
Note You need to log in before you can comment on or make changes to this bug.