| Summary: | Add a test for webkit.org/b/211311 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||
| Component: | HTML Editing | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bdakin, darin, megan_gardner, thorton, timothy, webkit-bug-importer, wenson_hsieh | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Wenson Hsieh
2020-05-01 13:42:16 PDT
Test for rdar://62663459 Created attachment 398235 [details]
Patch
Comment on attachment 398235 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398235&action=review > Tools/TestWebKitAPI/Tests/mac/AttributedString.mm:100 > + virtual void didLoadURL(WKView *wkView) { } I don’t understand this. Is this just the way to write a legacy-WebKit-only test? (In reply to Darin Adler from comment #3) > Comment on attachment 398235 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=398235&action=review > > > Tools/TestWebKitAPI/Tests/mac/AttributedString.mm:100 > > + virtual void didLoadURL(WKView *wkView) { } > > I don’t understand this. Is this just the way to write a legacy-WebKit-only > test? It isn’t the only way to test WebKitLegacy, but it’s the way these other attributed string tests in this file work, so I decided to go with the existing pattern. Committed r261037: <https://trac.webkit.org/changeset/261037> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398235 [details]. |