| Summary: | WebGPU: copyTextureToTexture() has an implementation bug (src copy view info is used also as dst) | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | gvinals | ||||||
| Component: | WebGPU | Assignee: | gvinals | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | changseok, dino, ews-watchlist, graouts, justin_fan, kondapallykalyan, mmaxfield, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
Created attachment 398302 [details]
Patch
Comment on attachment 398302 [details]
Patch
Patch looks good.
Created attachment 398385 [details]
Patch for committing
gvinals@apple.com does not have committer permissions according to https://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. Rejecting attachment 398385 [details] from commit queue. Committed r261089: <https://trac.webkit.org/changeset/261089> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398385 [details]. |
Summary: WebGPU: copyTextureToTexture() has an implementation bug (src copy view info is used also as dst). See: GPUCommandBufferMetal.mm#214,217 [blitEncoder() copyFromTexture:src.texture->platformTexture() sourceSlice:src.arrayLayer sourceLevel:src.mipLevel sourceOrigin:MTLOriginMake(src.origin.x, src.origin.y, src.origin.z) sourceSize:MTLSizeMake(size.width, size.height, size.depth) toTexture:dst.texture->platformTexture() destinationSlice:src.arrayLayer destinationLevel:src.mipLevel destinationOrigin:MTLOriginMake(dst.origin.x, dst.origin.y, dst.origin.z)]; In particular: destinationSlice:src.arrayLayer destinationLevel:src.mipLevel Should be: destinationSlice:dst.arrayLayer destinationLevel:dst.mipLevel