Bug 211299

Summary: TestWebKitAPI.WebKit.CustomDisplayName is a flaky timeout
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, darin, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=209993
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Comment 1 Radar WebKit Bug Importer 2020-05-01 10:22:05 PDT 
<rdar://problem/62734802>
Comment 2 Alex Christensen 2020-05-01 15:52:21 PDT 
Created attachment 398255 [details]
Patch
Comment 3 EWS 2020-05-04 11:00:50 PDT 
Committed r261090: <https://trac.webkit.org/changeset/261090>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398255 [details].
Comment 4 Alex Christensen 2020-05-04 12:52:25 PDT 
This test still times out on the bots sometimes after this fix.
Comment 5 Alex Christensen 2020-05-04 13:05:58 PDT 
Created attachment 398404 [details]
Patch
Comment 6 EWS 2020-05-04 14:04:27 PDT 
Committed r261112: <https://trac.webkit.org/changeset/261112>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398404 [details].
Comment 7 Alex Christensen 2020-05-04 15:19:06 PDT 
Reopening to attach new patch.
Comment 8 Alex Christensen 2020-05-04 15:19:08 PDT 
Created attachment 398425 [details]
Patch
Comment 9 Chris Dumez 2020-05-04 15:41:55 PDT 
Comment on attachment 398425 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398425&action=review

> Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:301
> +    dispatch_async(dispatch_get_global_queue(QOS_CLASS_BACKGROUND, 0), makeBlockPtr([completionHandler = WTFMove(completionHandler)] () mutable {

I think the issue is that dispatch_get_global_queue() returns a concurrent queue, not a serial queue, so ordering is not guaranteed.
Comment 10 Alex Christensen 2020-05-04 16:04:30 PDT 
Created attachment 398429 [details]
Patch
Comment 11 EWS 2020-05-04 21:50:34 PDT 
Committed r261145: <https://trac.webkit.org/changeset/261145>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398429 [details].
Comment 12 Alex Christensen 2020-05-04 23:33:25 PDT 
results.webkit.org indicates this is fixed!  hooray!