| Summary: | Sending WebRTC network packets should not go through the main thread | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||||||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||
| Severity: | Normal | CC: | cdumez, eric.carlson, esprehn+autocc, ews-watchlist, glenn, hta, jer.noble, kangil.han, philipj, sergio, tommyw, webkit-bug-importer, youennf | ||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||
| Version: | WebKit Local Build | ||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
|
Description
youenn fablet
2020-05-01 07:33:07 PDT
Created attachment 398182 [details]
Patch
Comment on attachment 398182 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398182&action=review > Source/WebKit/WebProcess/Network/webrtc/LibWebRTCSocket.cpp:61 > void LibWebRTCSocket::sendOnMainThread(Function<void(IPC::Connection&)>&& callback) Should this be renamed now that it doesn't send on the main thread? (In reply to Eric Carlson from comment #2) > Comment on attachment 398182 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=398182&action=review > > > Source/WebKit/WebProcess/Network/webrtc/LibWebRTCSocket.cpp:61 > > void LibWebRTCSocket::sendOnMainThread(Function<void(IPC::Connection&)>&& callback) > > Should this be renamed now that it doesn't send on the main thread? Right, we also need a better handling of getting the IPC::Connection. The callOnMainThreadAndWait should be removed to ensure we do not end up in a deadlock. Created attachment 398508 [details]
Patch
Created attachment 398509 [details]
Patch
Created attachment 398604 [details]
Patch
Created attachment 398612 [details]
Patch
Created attachment 398613 [details]
Patch
Comment on attachment 398613 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398613&action=review > Source/WebCore/ChangeLog:12 > + Fix a case where the SDP would be badly formatted we do not have yet a MDNS name for the corresponding IP address. s/would be badly formatted we do not have yet a MDNS name/would be badly formatted if we do not yet have an MDNS name/ > Source/WebCore/ChangeLog:13 > + Small refactoring to use less else if s/use less else if/use early returns/ Created attachment 398634 [details]
Patch for landing
Created attachment 398714 [details]
Patch for landing
Committed r261277: <https://trac.webkit.org/changeset/261277> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398714 [details]. |