| Summary: | Receiving WebRTC network packets should not go through the main thread | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | achristensen, annulen, eric.carlson, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio, webkit-bug-importer, youennf | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=222054 | ||||||||||||||||
| Bug Depends on: | 211924 | ||||||||||||||||
| Bug Blocks: | |||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
youenn fablet
2020-05-01 07:27:11 PDT
Created attachment 398184 [details]
Patch
Created attachment 398190 [details]
Patch
Created attachment 398196 [details]
Patch
Created attachment 398362 [details]
Patch
Comment on attachment 398362 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398362&action=review > Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetwork.cpp:119 > + if (auto* socket = m_socketFactory.socket(identifier)) You should probably add assertions to these. ASSERT(!RunLoop::isMain()); Created attachment 398489 [details]
Patch for landing
Created attachment 398494 [details]
WinCairo build fix
Committed r261163: <https://trac.webkit.org/changeset/261163> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398494 [details]. |