Bug 211278

Summary:

Reduce data copies in the WebContent process custom URL scheme handler

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

New Bugs

Assignee:

Jer Noble <jer.noble>

Status:

NEW ---

Severity:

Normal

CC:

achristensen, beidson, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	dbates: review+

Description Jer Noble 2020-04-30 22:16:35 PDT

Reduce data copies in the WebContent process custom URL scheme handler

Comment 1 Jer Noble 2020-04-30 22:21:50 PDT

Created attachment 398160 [details]
Patch

Comment 2 Radar WebKit Bug Importer 2020-04-30 22:23:50 PDT

<rdar://problem/62702860>

Comment 3 Daniel Bates 2020-05-01 12:55:09 PDT

Comment on attachment 398160 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398160&action=review

Patch looks good.

> Source/WebKit/WebProcess/WebPage/WebURLSchemeHandlerProxy.h:62
> +    void taskDidReceiveBuffer(uint64_t taskIdentifier, Ref<WebCore::SharedBuffer>&& data);

Ok as is. No change needed. Optimal solution doesn't name the buffer arg.