Bug 211269

Summary: [iOS] Fix confusing idiom for releasing _selectionRects in -[WKTextRange dealloc]
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: WebKit2Assignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: iseenoface, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch v1 none

David Kilzer (:ddkilzer)
Reported 2020-04-30 18:23:15 PDT
Fix confusing idiom for releasing _selectionRects in -[WKTextRange dealloc]. This fixes a false positive warning from the clang static analyzer about releasing a variable not owned by the caller.
Attachments
Patch v1 (1.45 KB, patch)
2020-04-30 18:24 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2020-04-30 18:24:08 PDT
Created attachment 398130 [details] Patch v1
David Kilzer (:ddkilzer)
Comment 2 2020-04-30 20:24:16 PDT
Comment on attachment 398130 [details] Patch v1 This is a WK2-only patch, so marking cq+ before mac-debug-wk1 tests are run (skipped).
EWS
Comment 3 2020-04-30 20:26:25 PDT
Committed r260980: <https://trac.webkit.org/changeset/260980> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398130 [details].
Radar WebKit Bug Importer
Comment 4 2020-04-30 20:27:13 PDT
<rdar://problem/62697108>
Note You need to log in before you can comment on or make changes to this bug.