Bug 211269

Summary: [iOS] Fix confusing idiom for releasing _selectionRects in -[WKTextRange dealloc]
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: WebKit2Assignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: iseenoface, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch v1 none

Description David Kilzer (:ddkilzer) 2020-04-30 18:23:15 PDT 
Fix confusing idiom for releasing _selectionRects in -[WKTextRange dealloc].

This fixes a false positive warning from the clang static analyzer about releasing a variable not owned by the caller.
Comment 1 David Kilzer (:ddkilzer) 2020-04-30 18:24:08 PDT 
Created attachment 398130 [details]
Patch v1
Comment 2 David Kilzer (:ddkilzer) 2020-04-30 20:24:16 PDT 
Comment on attachment 398130 [details]
Patch v1

This is a WK2-only patch, so marking cq+ before mac-debug-wk1 tests are run (skipped).
Comment 3 EWS 2020-04-30 20:26:25 PDT 
Committed r260980: <https://trac.webkit.org/changeset/260980>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398130 [details].
Comment 4 Radar WebKit Bug Importer 2020-04-30 20:27:13 PDT 
<rdar://problem/62697108>