| Summary: | REGRESSION (r258994): Prevents diagnostic logging of network resource loads | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||
| Component: | WebKit2 | Assignee: | Brent Fulgham <bfulgham> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ahmad.saleem792, mjs, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | 209522 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Brent Fulgham
2020-04-30 16:31:14 PDT
Created attachment 398121 [details]
Patch
After speaking with Maciej, we will do this another way. We spoke again, and will take this change, but we need to hold off until a blocking bug is fixed. Note: Holding for <rdar://problem/62727212> to be landed. Comment on attachment 398121 [details]
Patch
Maybe this is a stretch, but is it possible to make an API test that verifies that logging happens when it's supposed to (and not when it isn't supposed to, i.e. private browsing)?
In any case, r=me
(In reply to Brent Fulgham from comment #5) > Note: Holding for <rdar://problem/62727212> to be landed. Actually, it's <rdar://problem/62901456> we are holding for. Checking by BugID, it seems this r+ patch didn't landed. Do we need this now? Thanks! Oh! The relevant changes landed in https://trac.webkit.org/changeset/262332/webkit, after coordinating with the CFNetwork changes needed here. We can close this. The fix shipped back in 2020. |