Bug 211251

Summary: Web Inspector: Browser: crash when handling `disable`
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: hi, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Description Devin Rousso 2020-04-30 14:07:24 PDT 
ASSERTION FAILED: inspector
/Volumes/DATA/OpenSource/Source/WebKit/UIProcess/Inspector/Agents/InspectorBrowserAgent.cpp(91) : virtual void WebKit::InspectorBrowserAgent::disable(WebKit::ErrorString &)
1   0x10dcc8919 WTFCrash
2   0x114704d8b WTFCrashWithInfo(int, char const*, char const*, int)
3   0x1158b1234 WebKit::InspectorBrowserAgent::disable(WTF::String&)
4   0x1158b1140 WebKit::InspectorBrowserAgent::willDestroyFrontendAndBackend(Inspector::DisconnectReason)
5   0x10ee6e7fc Inspector::AgentRegistry::willDestroyFrontendAndBackend(Inspector::DisconnectReason)
6   0x1158ae225 WebKit::WebPageInspectorController::disconnectFrontend(Inspector::FrontendChannel&)
7   0x1158ab5d5 WebKit::WebInspectorProxy::closeFrontendPageAndWindow()
8   0x1158ab49c WebKit::WebInspectorProxy::invalidate()
9   0x1155a8587 WebKit::WebPageProxy::close()
10  0x1157c066d WKPageClose
Comment 1 Devin Rousso 2020-04-30 14:24:21 PDT 
Created attachment 398090 [details]
Patch
Comment 2 Daniel Bates 2020-05-01 13:09:49 PDT 
Comment on attachment 398090 [details]
Patch

Patch looks good. A better patch would add a unit test for this as it looks testable.
Comment 3 EWS 2020-05-01 14:09:56 PDT 
Committed r261020: <https://trac.webkit.org/changeset/261020>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398090 [details].
Comment 4 Radar WebKit Bug Importer 2020-05-01 14:10:19 PDT 
<rdar://problem/62746484>