| Summary: | results.webkit.org: Dropped connections when uploading archives shouldn't be fatal | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||||||||
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | aakash_jain, ews-watchlist, glenn, ryanhaddad, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Jonathan Bedard
2020-04-30 12:25:22 PDT
Created attachment 398081 [details]
Patch
Inspired by events like this: https://build.webkit.org/builders/Apple%20iOS%2013%20Simulator%20Debug%20WK2%20%28Tests%29/builds/3427/steps/layout-test/logs/stdio Created attachment 398083 [details]
Patch
Comment on attachment 398083 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398083&action=review > Tools/Scripts/webkitpy/results/upload.py:229 > + log_line_func(' ' * 4 + 'Failed to upload test archive to {}, results server dropped connection, likely due to archive size.'.format(hostname)) Can we also print the archive size here? > Tools/Scripts/webkitpy/results/upload.py:231 > + return True What happens is server is down or unreachable? Do we still use this code path or print a different error? Comment on attachment 398083 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398083&action=review >> Tools/Scripts/webkitpy/results/upload.py:231 >> + return True > > What happens is server is down or unreachable? Do we still use this code path or print a different error? It does, but it’s unlikely we would ever get into that circumstance because the result upload would have also failed. Comment on attachment 398083 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398083&action=review >> Tools/Scripts/webkitpy/results/upload.py:231 >> + return True > > What happens is server is down or unreachable? Do we still use this code path or print a different error? It does, but it’s unlikely we would ever get into that circumstance because the result upload would have also failed. Created attachment 398150 [details]
Patch
Created attachment 398185 [details]
Patch
Committed r261000: <https://trac.webkit.org/changeset/261000> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398185 [details]. |