Bug 211243

Summary: REGRESSION (r176862, r210483): Leaks of BrowserWindowController in MiniBrowser/mac/AppDelegate.m
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Tools / TestsAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: REOPENED ---    
Severity: Normal CC: commit-queue, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=211235
Bug Depends on: 139308, 166801, 211587    
Bug Blocks: 211586    
Attachments:
Description Flags
Patch v1 none

Description David Kilzer (:ddkilzer) 2020-04-30 11:46:41 PDT 
Leaks of BrowserWindowController in MiniBrowser/mac/AppDelegate.m.

Regressed here:

    Bug 139308: Add a private browsing mode to MiniBrowser
    <https://bugs.webkit.org/show_bug.cgi?id=139308>
    <https://trac.webkit.org/r176862>

    Bug 166801: Add the ability to create empty contentEditable windows in MiniBrowser
    <https://bugs.webkit.org/show_bug.cgi?id=166801>
    <https://trac.webkit.org/r210483>

Found by clang static analyzer.
Comment 1 David Kilzer (:ddkilzer) 2020-04-30 11:48:54 PDT 
Created attachment 398073 [details]
Patch v1
Comment 2 Radar WebKit Bug Importer 2020-04-30 11:49:13 PDT 
<rdar://problem/62663549>
Comment 3 David Kilzer (:ddkilzer) 2020-04-30 11:59:28 PDT 
Comment on attachment 398073 [details]
Patch v1

MiniBrowser is not used in automated testing, so marking cq+ after all builds completed successfully.
Comment 4 EWS 2020-04-30 12:19:50 PDT 
Committed r260959: <https://trac.webkit.org/changeset/260959>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398073 [details].
Comment 5 WebKit Commit Bot 2020-05-07 11:55:19 PDT 
Re-opened since this is blocked by bug 211587
Comment 6 Radar WebKit Bug Importer 2020-05-07 12:13:25 PDT 
<rdar://problem/62987575>