Bug 211242

Summary: REGRESSION (r247490): Leak of MiniBrowserNSTextFinder._hideInterfaceCallback
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Tools / TestsAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 199815    
Bug Blocks:    
Attachments:
Description Flags
Patch v1
none
Patch v2 none

Description David Kilzer (:ddkilzer) 2020-04-30 11:23:53 PDT
Leak of MiniBrowserNSTextFinder._hideInterfaceCallback.

Caused by:

    Bug 199815: NSTextFinder holes don't scroll with the page
    <https://bugs.webkit.org/show_bug.cgi?id=199815>
    <rdar://problem/52280514>
    <https://trac.webkit.org/r247490>
Comment 1 David Kilzer (:ddkilzer) 2020-04-30 11:26:10 PDT
Created attachment 398070 [details]
Patch v1
Comment 2 David Kilzer (:ddkilzer) 2020-04-30 11:28:56 PDT
Created attachment 398071 [details]
Patch v2
Comment 3 David Kilzer (:ddkilzer) 2020-04-30 11:29:47 PDT
(In reply to David Kilzer (:ddkilzer) from comment #1)
> Created attachment 398070 [details]
> Patch v1

Helps if you spell -release correctly.
Comment 4 Radar WebKit Bug Importer 2020-04-30 11:30:09 PDT
<rdar://problem/62662394>
Comment 5 Tim Horton 2020-04-30 11:30:57 PDT
Comment on attachment 398071 [details]
Patch v2

We should totally ARC minibrowser
Comment 6 Radar WebKit Bug Importer 2020-04-30 11:30:58 PDT
<rdar://problem/62662314>
Comment 7 David Kilzer (:ddkilzer) 2020-04-30 11:39:30 PDT
<rdar://problem/62662394>
Comment 8 David Kilzer (:ddkilzer) 2020-04-30 11:58:51 PDT
Comment on attachment 398071 [details]
Patch v2

MiniBrowser is not used in automated testing, so marking cq+ after all builds completed successfully.
Comment 9 EWS 2020-04-30 12:01:35 PDT
Committed r260958: <https://trac.webkit.org/changeset/260958>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398071 [details].