Bug 211240

Summary: WebCore::systemHasBattery() is unnecessarily expensive on iOS
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Chris Dumez 2020-04-30 10:51:51 PDT 
WebCore::systemHasBattery() is unnecessarily expensive on iOS since iOS devices always have a battery.
Comment 1 Chris Dumez 2020-04-30 10:52:01 PDT 
<rdar://problem/62619971>
Comment 2 Chris Dumez 2020-04-30 10:53:43 PDT 
Created attachment 398066 [details]
Patch
Comment 3 Geoffrey Garen 2020-04-30 11:01:35 PDT 
Comment on attachment 398066 [details]
Patch

I look forward to finding this code ten years from now, to fix a new hardware bug. 😬
Comment 4 EWS 2020-04-30 12:43:19 PDT 
Committed r260960: <https://trac.webkit.org/changeset/260960>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398066 [details].