| Summary: | Ensure Intl classes don't have naming conflicts with unified builds | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ross Kirsling <ross.kirsling> | ||||||
| Component: | New Bugs | Assignee: | Ross Kirsling <ross.kirsling> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | darin, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Ross Kirsling
2020-04-29 17:54:36 PDT
Created attachment 398012 [details]
Patch
Comment on attachment 398012 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398012&action=review r=me > Source/JavaScriptCore/runtime/IntlCollator.h:60 > + static Vector<String> sortLocaleData(const String&, size_t); > + static Vector<String> searchLocaleData(const String&, size_t); > + Let's put it behind private: if possible. > Source/JavaScriptCore/runtime/IntlDateTimeFormat.h:57 > + static Vector<String> localeData(const String&, size_t); Ditto. > Source/JavaScriptCore/runtime/IntlNumberFormat.h:58 > + static Vector<String> localeData(const String&, size_t); Ditto. > Source/JavaScriptCore/runtime/IntlPluralRules.h:56 > + static Vector<String> localeData(const String&, size_t); Ditto. > Source/JavaScriptCore/runtime/IntlRelativeTimeFormat.h:55 > + static Vector<String> localeData(const String&, size_t); Ditto. Created attachment 398021 [details]
Patch for landing
Committed r260931: <https://trac.webkit.org/changeset/260931> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398021 [details]. Comment on attachment 398021 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=398021&action=review > Source/JavaScriptCore/runtime/IntlCollator.h:71 > + static Vector<String> sortLocaleData(const String&, size_t); > + static Vector<String> searchLocaleData(const String&, size_t); Avoiding name conflict is a good thing. Adding more in headers is not such a good thing. I guess I’m OK with this, but generally would be nice to have the headers be as small as possible and not have implementation details that they don’t need to. |