| Summary: | EWS should skip Apple Win build and tests for patches that only change WebKit2 sources | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aakash_jain, ap, bfulgham, don.olmstead, Hironori.Fujii, jbedard, pvollan, ryanhaddad, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=210115 https://bugs.webkit.org/show_bug.cgi?id=234911 |
||||||
| Attachments: |
|
||||||
|
Description
David Kilzer (:ddkilzer)
2020-04-29 15:37:23 PDT
Is this applicable to WinCairo as well? (wincairo ews doesn't run tests, only builds) Created attachment 398383 [details]
Patch
(In reply to Aakash Jain from comment #1) > Is this applicable to WinCairo as well? (wincairo ews doesn't run tests, > only builds) I don't think this is applicable to WinCairo. (In reply to Per Arne Vollan from comment #3) > I don't think this is applicable to WinCairo. ok. the attached patch is only for Apple Windows platform. Committed r261184: <https://trac.webkit.org/changeset/261184> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398383 [details]. Deployed on server yesterday. Seems to be working fine. e.g.: https://ews-build.webkit.org/#/builders/10/builds/17575 https://ews-build.webkit.org/#/builders/10/builds/17563 Comment on attachment 398383 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398383&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:307 > + 'windows': wk1_paths, This code has a problem. Filed: Bug 234911 – AppleWin EWS check-patch-relevance skips a patch for Source/cmake/*.cmake |