Bug 211209

Summary: Change default of "inAppBrowserPrivacyQuirks" testing toggle to use it for tests only
Product: WebKit Reporter: Kate Cheney <katherine_cheney>
Component: WebKit Misc.Assignee: Kate Cheney <katherine_cheney>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Kate Cheney 2020-04-29 15:07:46 PDT 
This was used to test certain In-App Browser Privacy quirks. It is no longer needed, so we can delete it.
Comment 1 Radar WebKit Bug Importer 2020-04-29 15:08:08 PDT 
<rdar://problem/62619659>
Comment 2 Kate Cheney 2020-04-29 16:24:17 PDT 
(In reply to katherine_cheney from comment #0)
> This was used to test certain In-App Browser Privacy quirks. It is no longer
> needed, so we can delete it.

After a bit of thinking, this flag is actually still needed for tests. We can change the default value and set it manually in tests which need it for script evaluation purposes.
Comment 3 Kate Cheney 2020-04-29 16:37:16 PDT 
Created attachment 398008 [details]
Patch
Comment 4 Brent Fulgham 2020-04-30 14:09:27 PDT 
Comment on attachment 398008 [details]
Patch

Looks good. r=me.
Comment 5 EWS 2020-04-30 14:39:11 PDT 
Committed r260968: <https://trac.webkit.org/changeset/260968>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398008 [details].