Bug 211204

Summary:

build-jsc should quote the value of compile flags it forwards

Product:

WebKit

Reporter:

Saam Barati <saam>

Component:

JavaScriptCore

Assignee:

Saam Barati <saam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, fpizlo, ggaren, gskachkov, guijemont, keith_miller, mark.lam, msaboff, rmorisset, ross.kirsling, ticaiolima, tzagallo, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none

Description Saam Barati 2020-04-29 13:56:09 PDT

For example, we do the wrong thing now with make when doing
$ build-jsc --release ARCHS="x86_64 i386"
We invoke make as
$ make release ARCHS=x86_64 i386
instead of
$ make release ARCHS="x86_64 i386"

Comment 1 Saam Barati 2020-04-29 14:16:45 PDT

Created attachment 397997 [details]
patch

Comment 2 Mark Lam 2020-04-29 14:25:00 PDT

Comment on attachment 397997 [details]
patch

rs=me

Comment 3 EWS 2020-04-29 14:57:46 PDT

Committed r260917: <https://trac.webkit.org/changeset/260917>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397997 [details].

Comment 4 Radar WebKit Bug Importer 2020-04-29 14:58:14 PDT

<rdar://problem/62619195>