Bug 211202

Summary: [iOS][WK2] Add timeout for "Client navigation" foreground assertion
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Chris Dumez 2020-04-29 13:31:36 PDT 
Add timeout for "Client navigation" foreground assertion. Foreground assertions do not timeout at RunningBoard level and we thus need to make sure we release them to avoid power leaks.
Comment 1 Chris Dumez 2020-04-29 13:33:45 PDT 
Created attachment 397993 [details]
Patch
Comment 2 Alex Christensen 2020-04-30 13:12:47 PDT 
Comment on attachment 397993 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397993&action=review

> Source/WebKit/UIProcess/API/APINavigation.cpp:70
> +    , m_clientNavigationActivity(navigationActivityTimeout)

I feel like this kind of initialization can be done with an initializer list in the header.
Comment 3 EWS 2020-04-30 14:19:19 PDT 
Committed r260966: <https://trac.webkit.org/changeset/260966>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397993 [details].
Comment 4 Radar WebKit Bug Importer 2020-04-30 14:20:14 PDT 
<rdar://problem/62673956>