Bug 211200

Summary: Style is not applied when changed on the first line of a new mail message.
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, ews-watchlist, mifenton, thorton, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
darin: review+
Patch none

Description Megan Gardner 2020-04-29 13:04:19 PDT 
Style is not applied when changed on the first line of a new mail message.
Comment 1 Megan Gardner 2020-04-29 13:05:01 PDT Comment hidden (obsolete)
Comment 2 Megan Gardner 2020-04-30 18:26:11 PDT Comment hidden (obsolete)
Comment 3 Megan Gardner 2020-04-30 18:26:52 PDT 
<rdar://problem/62087514>
Comment 4 Megan Gardner 2020-05-01 16:30:27 PDT Comment hidden (obsolete)
Comment 5 Megan Gardner 2020-05-01 16:31:59 PDT Comment hidden (obsolete)
Comment 6 Megan Gardner 2020-05-01 16:36:51 PDT Comment hidden (obsolete)
Comment 7 Megan Gardner 2020-05-04 14:20:29 PDT Comment hidden (obsolete)
Comment 8 Megan Gardner 2020-05-04 17:56:55 PDT Comment hidden (obsolete)
Comment 9 Darin Adler 2020-05-04 23:37:41 PDT 
Comment on attachment 398448 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398448&action=review

> LayoutTests/editing/execCommand/ios/first-line-text-attribute-change-presist-through-resigning-first-responder-expected.txt:3
> +U

This "U" line doesn’t seem to be present in the actual test output given what the EWS bot says.
Comment 10 Darin Adler 2020-05-04 23:43:03 PDT 
Comment on attachment 398448 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398448&action=review

r=me after you get the test to pass on EWS; right now it’s failing

> Tools/WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:71
> +#if PLATFORM(MAC)
> +    [[webView() window] makeFirstResponder:nil];
> +#else
>      [webView() resignFirstResponder];
> +#endif

I don’t think you should land this Mac-only change as part of this patch, since the test is an iOS-only test. I assume it’s not needed to make some other test pass on Mac?

I believe UIScriptControllerCocoa::becomeFirstResponder is also incorrect on Mac in the same sort of way. And should be fixed the same way, by calling [window makeFirstResponder:self]. Maybe not right now as part of this patch, though.

> LayoutTests/ChangeLog:10
> +        * editing/execCommand/ios/first-line-text-attribute-change-presist-through-resigning-first-responder.html: Added.

Why is this an iOS-only test? I couldn't find anything iOS-specific in it.
Comment 11 Megan Gardner 2020-05-05 08:28:24 PDT 
Comment on attachment 398448 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398448&action=review

>> LayoutTests/ChangeLog:10
>> +        * editing/execCommand/ios/first-line-text-attribute-change-presist-through-resigning-first-responder.html: Added.
> 
> Why is this an iOS-only test? I couldn't find anything iOS-specific in it.

It is the testing of resigningFirstResponder that is iOS specific. We do not resign at the same or similar times on Mac.
Comment 12 Megan Gardner 2020-05-05 08:30:30 PDT 
Created attachment 398511 [details]
Patch
Comment 13 EWS 2020-05-05 09:51:31 PDT 
Committed r261177: <https://trac.webkit.org/changeset/261177>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398511 [details].