| Summary: | REGRESSION (r246395): Leak of ARQuickLookPreviewItem and ARQuickLookWebKitItem in -[_WKPreviewControllerDataSource previewController:previewItemAtIndex:] | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||||||
| Component: | WebKit2 | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | darin, graouts, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | Other | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | 198812 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
David Kilzer (:ddkilzer)
2020-04-29 12:20:08 PDT
Created attachment 397985 [details]
Patch v1
Created attachment 397988 [details]
Patch v2
(In reply to David Kilzer (:ddkilzer) from comment #3) > Created attachment 397988 [details] > Patch v2 Fixed build error: - previewItem.canonicalWebPageURL = _originatingPageURL; + previewItem.get().canonicalWebPageURL = _originatingPageURL; Comment on attachment 397988 [details] Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=397988&action=review > Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:113 > + previewItem.get().canonicalWebPageURL = _originatingPageURL; Some WebKit contributors prefer this style to sidestep the get(): [previewItem setCanonicalWebPageURL:_originatingPageURL]; Comment on attachment 397988 [details] Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=397988&action=review >> Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:113 >> + previewItem.get().canonicalWebPageURL = _originatingPageURL; > > Some WebKit contributors prefer this style to sidestep the get(): > > [previewItem setCanonicalWebPageURL:_originatingPageURL]; Wasn't sure if new-style Objective-C setters (with .get()) were preferred over old-style setter syntax (but no .get()). Comment on attachment 397988 [details] Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=397988&action=review >>> Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:113 >>> + previewItem.get().canonicalWebPageURL = _originatingPageURL; >> >> Some WebKit contributors prefer this style to sidestep the get(): >> >> [previewItem setCanonicalWebPageURL:_originatingPageURL]; > > Wasn't sure if new-style Objective-C setters (with .get()) were preferred over old-style setter syntax (but no .get()). Tim Horton was the one who explained the lack of Objective-C setters in another patch, by citing this. Created attachment 397999 [details]
Patch for landing
Comment on attachment 397999 [details]
Patch for landing
Marking cq+ because "Patch v2" has passed all tests except one ios-wk2 test (fast/text/text-indent-inside-float.html) which this patch is not likely to have affected.
Committed r260922: <https://trac.webkit.org/changeset/260922> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397999 [details]. |