Bug 211186

Summary:

[GTK4] Bring back the URI entry to MiniBrowser

Product:

WebKit

Reporter:

Claudio Saavedra <csaavedra>

Component:

WebKitGTK

Assignee:

Claudio Saavedra <csaavedra>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bugs-noreply, cgarcia

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch for landing	none

Description Claudio Saavedra 2020-04-29 09:03:40 PDT

[GTK4] Bring back the URI entry to MiniBrowser

Comment 1 Claudio Saavedra 2020-04-29 09:05:06 PDT

Created attachment 397965 [details]
Patch

Comment 2 Carlos Garcia Campos 2020-04-30 02:59:32 PDT

Comment on attachment 397965 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397965&action=review

> Tools/MiniBrowser/gtk/BrowserWindow.c:523
> +        GBytes *bytes = g_bytes_new_static(cairo_image_surface_get_data(surface), stride*height);

stride*height -> stride * height

I'm afraid we need to copy the data here, the favicon is owned by the web view and will be deleted on navigation.

Comment 3 Claudio Saavedra 2020-04-30 04:16:08 PDT

Created attachment 398047 [details]
Patch

Comment 4 Carlos Garcia Campos 2020-04-30 04:31:18 PDT

Comment on attachment 398047 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398047&action=review

> Tools/MiniBrowser/gtk/BrowserWindow.c:117
> +#if GTK_CHECK_VERSION(3, 98, 0)
> +                            gtk_editable_get_text(GTK_EDITABLE(window->uriEntry))
> +#else
> +                            gtk_entry_get_text(GTK_ENTRY(window->uriEntry))
> +#endif

Indentation is wrong here.

Comment 5 Claudio Saavedra 2020-04-30 04:44:44 PDT

Created attachment 398048 [details]
Patch for landing

Comment 6 EWS 2020-04-30 05:10:24 PDT

Committed r260942: <https://trac.webkit.org/changeset/260942>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398048 [details].