Bug 211150

Summary: Add StringView::isAllSpecialCharacters()
Product: WebKit Reporter: Noam Rosenthal <noam>
Component: WebCore Misc.Assignee: Noam Rosenthal <noam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, darin, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, mmaxfield, pdr, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Noam Rosenthal
Reported 2020-04-28 15:38:43 PDT
As a followup to https://bugs.webkit.org/show_bug.cgi?id=208499, avoid creating a StringImpl just for the purpose of testing for whitespace-only.
Attachments
Patch (3.21 KB, patch)
2020-04-28 15:43 PDT, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.50 KB, patch)
2020-04-28 22:21 PDT, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.22 KB, patch)
2020-04-28 23:26 PDT, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Noam Rosenthal
Comment 1 2020-04-28 15:43:44 PDT
Created attachment 397892 [details] Patch
Darin Adler
Comment 2 2020-04-28 15:50:35 PDT
Comment on attachment 397892 [details] Patch Note that TextManipulationController.cpp contains a function named containsOnlyHTMLSpaces.
EWS
Comment 3 2020-04-28 16:31:04 PDT
Patch 397892 does not build
Noam Rosenthal
Comment 4 2020-04-28 22:21:37 PDT
Created attachment 397925 [details] Patch for landing
EWS
Comment 5 2020-04-28 23:06:13 PDT
Patch 397925 does not build
Noam Rosenthal
Comment 6 2020-04-28 23:26:48 PDT
Created attachment 397931 [details] Patch for landing
EWS
Comment 7 2020-04-29 00:09:49 PDT
Committed r260881: <https://trac.webkit.org/changeset/260881> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397931 [details].
Radar WebKit Bug Importer
Comment 8 2020-04-29 00:10:15 PDT
<rdar://problem/62579354>
Note You need to log in before you can comment on or make changes to this bug.