Bug 211150

Summary: Add StringView::isAllSpecialCharacters()
Product: WebKit Reporter: Noam Rosenthal <noam>
Component: WebCore Misc.Assignee: Noam Rosenthal <noam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, darin, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, mmaxfield, pdr, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Description Noam Rosenthal 2020-04-28 15:38:43 PDT
As a followup to  https://bugs.webkit.org/show_bug.cgi?id=208499, avoid creating a StringImpl just for the purpose of testing for whitespace-only.
Comment 1 Noam Rosenthal 2020-04-28 15:43:44 PDT
Created attachment 397892 [details]
Patch
Comment 2 Darin Adler 2020-04-28 15:50:35 PDT
Comment on attachment 397892 [details]
Patch

Note that TextManipulationController.cpp contains a function named containsOnlyHTMLSpaces.
Comment 3 EWS 2020-04-28 16:31:04 PDT
Patch 397892 does not build
Comment 4 Noam Rosenthal 2020-04-28 22:21:37 PDT
Created attachment 397925 [details]
Patch for landing
Comment 5 EWS 2020-04-28 23:06:13 PDT
Patch 397925 does not build
Comment 6 Noam Rosenthal 2020-04-28 23:26:48 PDT
Created attachment 397931 [details]
Patch for landing
Comment 7 EWS 2020-04-29 00:09:49 PDT
Committed r260881: <https://trac.webkit.org/changeset/260881>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397931 [details].
Comment 8 Radar WebKit Bug Importer 2020-04-29 00:10:15 PDT
<rdar://problem/62579354>