| Summary: | Delay SystemStatus call from process launch to when being useful | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||
| Status: | RESOLVED CONFIGURATION CHANGED | ||||||||||
| Severity: | Normal | CC: | bfulgham, eric.carlson, ews-watchlist, ggaren, glenn, hta, jer.noble, nham, philipj, pvollan, sergio, tommyw, youennf | ||||||||
| Priority: | P2 | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
youenn fablet
2020-04-28 04:55:17 PDT
Created attachment 397830 [details]
Patch
Created attachment 397831 [details]
Patch
Comment on attachment 397831 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397831&action=review > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:178 > + (allow mach-lookup (global-name "com.apple.systemstatus.activityattribution")) Sorry, I should have realized this earlier — I don’t think we can take this approach. Since we’re no loner calling the status function on startup, this patch has to include an unsafe privileged service in the sandbox. That’s a pretty serious sandbox regression relative to all the work we’ve done lately. I don’t think that’s ok. I guess we need to talk to the systemstatus and integration folks to find some way forward that allows strong linking. 😞 Created attachment 397836 [details]
Patch
Comment on attachment 397836 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397836&action=review > Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:41 > +#include "PlatformMediaSessionManager.h" Nit: is this necessary? > Source/WebCore/platform/mock/MockRealtimeMediaSourceCenter.cpp:39 > +#include "PlatformMediaSessionManager.h" Ditto We will go with another approach that is much less complex. |