| Summary: | Web Inspector: Debug: "Outline focused element" should also outline elements with tabIndex=0 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Nikita Vasilyev <nvasilyev> | ||||||
| Component: | Web Inspector | Assignee: | Nikita Vasilyev <nvasilyev> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | hi, inspector-bugzilla-changes, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
Created attachment 397776 [details]
Patch
Comment on attachment 397776 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397776&action=review r=me > Source/WebInspectorUI/UserInterface/Debug/Bootstrap.css:26 > +body.focus-debug [tabindex="0"] { Would it be worth having additional colors for `[tabindex="-1"]` and `[tabindex]:not([tabindex="-1"], [tabindex="0"])` as well? Comment on attachment 397776 [details] Patch (In reply to Devin Rousso from comment #2) > Comment on attachment 397776 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=397776&action=review > > r=me > > > Source/WebInspectorUI/UserInterface/Debug/Bootstrap.css:26 > > +body.focus-debug [tabindex="0"] { > > Would it be worth having additional colors for `[tabindex="-1"]` and > `[tabindex]:not([tabindex="-1"], [tabindex="0"])` as well? I didn't find that particularly useful, personally. Committed r260853: <https://trac.webkit.org/changeset/260853> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397776 [details]. |
Created attachment 397775 [details] [Image] With patch applied Outlining elements with tabIndex=0 helps me to see what's tabbable and what isn't. It saves me time tabbing back and forth between elements.