Bug 211094

Summary: results.webkit.org: A suite running multiple times in a commit for a single configuration may pre-empt processing
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=211097
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Jonathan Bedard 2020-04-27 14:50:25 PDT 
This is a difficult issue to catch because it causes a race condition. If we manage to pick up the processing task before the next run reports, everything works as expected. If we report too quickly, though, we over-write the redis key of the first run.
Comment 1 Radar WebKit Bug Importer 2020-04-27 14:56:49 PDT 
<rdar://problem/62470170>
Comment 2 Jonathan Bedard 2020-04-27 14:58:39 PDT 
Created attachment 397746 [details]
Patch
Comment 3 Aakash Jain 2020-04-27 15:02:57 PDT 
Comment on attachment 397746 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397746&action=review

> Tools/resultsdbpy/resultsdbpy/model/upload_context.py:195
> +            hash_key = hash(configuration) ^ hash(branch) ^ hash(self.commit_context.uuid_for_commits(commits)) ^ hash(suite) ^ hash(timestamp)

Bug description or Changelog can be made more descriptive explaining that the hash key was colliding in certain cases.
Comment 4 Jonathan Bedard 2020-04-27 16:10:28 PDT 
Created attachment 397759 [details]
Patch for landing
Comment 5 EWS 2020-04-27 16:32:42 PDT 
Committed r260796: <https://trac.webkit.org/changeset/260796>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397759 [details].