| Summary: | Make HistoryController an inner class of FrameLoader | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Rob Buis <rbuis> | ||||||
| Component: | New Bugs | Assignee: | Rob Buis <rbuis> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cdumez, darin, ews-watchlist, japhet, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | Safari Technology Preview | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Rob Buis
2020-04-27 13:11:19 PDT
Created attachment 397725 [details]
Patch
Comment on attachment 397725 [details]
Patch
PTAL. If this kind of design is acceptable I'd like to do the same for PolicyChecker and DocumentLoader, as especially the latter adds a lot of public API to FrameLoader that is only used by DocumentLoader, which could be made private. These classes all look tightly coupled to me BTW.
Comment on attachment 397725 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397725&action=review > Source/WebCore/loader/HistoryController.h:32 > -#include "FrameLoaderTypes.h" > +#include "FrameLoader.h" I’d think you could remove many of the includes below after making this change. Created attachment 397819 [details]
Patch
Committed r260812: <https://trac.webkit.org/changeset/260812> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397819 [details]. |