| Summary: | [Web Animations] Missing webAnimationsCSSIntegrationEnabled code path in RenderLayer::currentTransform() | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||||||
| Component: | Animations | Assignee: | Antoine Quint <graouts> | ||||||||
| Status: | NEW --- | ||||||||||
| Severity: | Normal | CC: | dino, esprehn+autocc, ews-watchlist, fred.wang, glenn, graouts, kondapallykalyan, krit, pdr, simon.fraser | ||||||||
| Priority: | P2 | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=201892 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Antoine Quint
2020-04-27 02:50:16 PDT
The only call site is RenderLayerBacking::getCurrentTransform(). Created attachment 397670 [details]
Patch
Created attachment 397682 [details]
Patch
Comment on attachment 397682 [details]
Patch
This is testable. Please also add an assertion in renderer().animation() or renamed to legacyAnimation().
^ testable like compositing/visible-rect/animated.html with non-default transform origin and an origin-sensitive transform like a rotate. This code was added in r251252, the fix to bug 201892. I'm renaming the accessor to legacyAnimation() in bug 211082. Not sure if we actually need to call animatedStyleForRenderer() here at all, I believe we can't end up in the `if (applyOrigin == RenderStyle::ExcludeTransformOrigin)` code branch with a running `transform` animation since it would be accelerated and thus we'd return earlier on in `RenderLayer::currentTransform()`. Created attachment 397851 [details]
Test
Here's a test that hits this codepath.
(In reply to Simon Fraser (smfr) from comment #9) > Created attachment 397851 [details] > Test > > Here's a test that hits this codepath. However it doesn't any behavior different pre and post patch. (In reply to Antoine Quint from comment #10) > (In reply to Simon Fraser (smfr) from comment #9) > > Created attachment 397851 [details] > > Test > > > > Here's a test that hits this codepath. > > However it doesn't any behavior different pre and post patch. I tried to modify the provided test to set a negative delay for the animation to be half-way through but the output is still the same with or without the patch. It should if you dump visible rects and/or tiling. The webAnimationsCSSIntegrationEnabled flag no longer exists, but this may yet still occur. |