| Summary: | Use static initialized Lock instead of LazyNeverDestroyed<Lock> | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cdumez, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, kondapallykalyan, mark.lam, mmaxfield, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Yusuke Suzuki
2020-04-24 23:00:16 PDT
Created attachment 397543 [details]
Patch
Comment on attachment 397543 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397543&action=review r=me > Source/WebCore/Modules/webgpu/WebGPUDevice.cpp:110 > +static Lock deviceMutex; Why not just declare it as a static inside its accessor function? Ditto below. Comment on attachment 397543 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397543&action=review Thanks! >> Source/WebCore/Modules/webgpu/WebGPUDevice.cpp:110 >> +static Lock deviceMutex; > > Why not just declare it as a static inside its accessor function? Ditto below. Yeah, right. We can put it in a function. Fixed! Committed r260714: <https://trac.webkit.org/changeset/260714> |