Bug 211010

Summary: Use static initialized Lock instead of LazyNeverDestroyed<Lock>
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, kondapallykalyan, mark.lam, mmaxfield, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mark.lam: review+

Yusuke Suzuki
Reported 2020-04-24 23:00:16 PDT
Use static initialized Lock instead of LazyNeverDestroyed<Lock>
Attachments
Patch (4.29 KB, patch)
2020-04-24 23:01 PDT, Yusuke Suzuki 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2020-04-24 23:01:09 PDT
Created attachment 397543 [details] Patch
Mark Lam
Comment 2 2020-04-24 23:05:38 PDT
Comment on attachment 397543 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397543&action=review r=me > Source/WebCore/Modules/webgpu/WebGPUDevice.cpp:110 > +static Lock deviceMutex; Why not just declare it as a static inside its accessor function? Ditto below.
Yusuke Suzuki
Comment 3 2020-04-25 17:16:47 PDT
Comment on attachment 397543 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397543&action=review Thanks! >> Source/WebCore/Modules/webgpu/WebGPUDevice.cpp:110 >> +static Lock deviceMutex; > > Why not just declare it as a static inside its accessor function? Ditto below. Yeah, right. We can put it in a function. Fixed!
Yusuke Suzuki
Comment 4 2020-04-25 17:32:04 PDT
Committed r260714: <https://trac.webkit.org/changeset/260714>
Radar WebKit Bug Importer
Comment 5 2020-04-25 17:33:14 PDT
<rdar://problem/62378157>
Note You need to log in before you can comment on or make changes to this bug.